chore: have on demand validity and patches for array remove slot extraction#7217
Merged
joseph-isaacs merged 18 commits intodevelopfrom Apr 1, 2026
Merged
chore: have on demand validity and patches for array remove slot extraction#7217joseph-isaacs merged 18 commits intodevelopfrom
joseph-isaacs merged 18 commits intodevelopfrom
Conversation
Merging this PR will degrade performance by 20.76%
Performance Changes
Comparing 
Footnotes
|
joseph-isaacs
changed the title
joseph-isaacs
added
the
action/benchmark
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-btrblocks/src/canonical_compressor.rs # vortex-btrblocks/src/compressor/decimal.rs # vortex-btrblocks/src/compressor/float/mod.rs # vortex-btrblocks/src/compressor/integer/mod.rs # vortex-btrblocks/src/compressor/string.rs
joseph-isaacs
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.914x ➖, 8↑ 0↓)
datafusion / vortex-compact (0.911x ➖, 9↑ 0↓)
datafusion / parquet (0.984x ➖, 2↑ 3↓)
datafusion / arrow (0.883x ✅, 15↑ 0↓)
duckdb / vortex-file-compressed (0.924x ➖, 4↑ 0↓)
duckdb / vortex-compact (0.934x ➖, 4↑ 0↓)
duckdb / parquet (0.959x ➖, 6↑ 3↓)
duckdb / duckdb (0.974x ➖, 0↑ 0↓)
Full attributed analysis
|
robert3005
approved these changes
Apr 1, 2026
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.977x ➖ datafusion / vortex-file-compressed (0.977x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.973x ➖, 1↑ 0↓)
datafusion / vortex-compact (1.003x ➖, 1↑ 0↓)
datafusion / parquet (1.024x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.030x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.007x ➖, 0↑ 0↓)
duckdb / parquet (1.016x ➖, 0↑ 0↓)
Full attributed analysis
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.963x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.966x ➖, 2↑ 0↓)
datafusion / parquet (0.966x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.978x ➖, 3↑ 0↓)
duckdb / vortex-compact (0.981x ➖, 1↑ 1↓)
duckdb / parquet (0.979x ➖, 1↑ 0↓)
duckdb / duckdb (0.990x ➖, 0↑ 2↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.110x ➖, 2↑ 7↓)
datafusion / vortex-compact (1.252x ➖, 0↑ 7↓)
datafusion / parquet (1.023x ➖, 2↑ 2↓)
duckdb / vortex-file-compressed (1.074x ➖, 0↑ 1↓)
duckdb / vortex-compact (0.981x ➖, 0↑ 2↓)
duckdb / parquet (1.031x ➖, 0↑ 2↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.214x ➖, 0↑ 3↓)
datafusion / vortex-compact (1.150x ➖, 0↑ 3↓)
datafusion / parquet (1.028x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.039x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.002x ➖, 0↑ 0↓)
duckdb / parquet (1.090x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.756x ✅ unknown / unknown (0.818x ✅, 46↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.984x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.001x ➖, 0↑ 0↓)
duckdb / parquet (0.997x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: CompressionVortex (geomean): 1.005x ➖ unknown / unknown (0.987x ➖, 11↑ 2↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR get rid of holding validity and patches on each ArrayData, instead we construct this on-demand.
This will also a follow up to have
slots_mut -> &mut [Option<ArrayRef>]instead ofwith_slots