Skip to content

lazy dict layout values eval #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onursatici merged 1 commit into from
Feb 11, 2026
Merged

lazy dict layout values eval #6423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions vortex-layout/src/layouts/dict/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ use futures::future::BoxFuture;
use futures::try_join;
use vortex_array::Array;
use vortex_array::ArrayRef;
use vortex_array::Canonical;
use vortex_array::ExecutionCtx;
use vortex_array::IntoArray;
use vortex_array::MaskFuture;
use vortex_array::VortexSessionExecute;
Expand Down Expand Up @@ -119,16 +117,13 @@ impl DictReader {
return fut.clone();
}

let session = self.session.clone();
self.values_evals
.entry(expr.clone())
.or_insert_with(|| {
self.values_array()
.map(move |array| {
let array = array?.apply(&expr)?;
// We execute the array to avoid re-evaluating for every split.
let mut ctx = ExecutionCtx::new(session);
Ok(array.execute::<Canonical>(&mut ctx)?.into_array())
Ok(SharedArray::new(array).into_array())
})
.boxed()
.shared()
Expand Down
Loading