lazy dict layout values eval #6423
Open
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onur Satici <[email protected]>
robert3005
approved these changes
Feb 11, 2026
Comment on lines
123
to
+126
| self.values_array() | ||
| .map(move |array| { | ||
| let array = array?.apply(&expr)?; | ||
| // We execute the array to avoid re-evaluating for every split. | ||
| let mut ctx = ExecutionCtx::new(session); | ||
| Ok(array.execute::<Canonical>(&mut ctx)?.into_array()) | ||
| Ok(SharedArray::new(array).into_array()) |
Contributor
There was a problem hiding this comment.
this has double shared arrays ?
Contributor
Author
There was a problem hiding this comment.
yes, the first one to cache the values as is, and this caches the result of the expression, so it only is executed in the first split
Contributor
Author
There was a problem hiding this comment.
if the expr is root we would have shared(shared(values)) which is redundant but should be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR closes an open issue or discussion?
What changes are included in this PR?
make values child evaluation of an expression in the projection evaluation of a dict layout lazy. We want this because the current execute is assuming cpu only, with shared array we defer to the actual execute call to choose which execution it wants
What is the rationale for this change?
How is this change tested?
Are there any user-facing changes?