Replace deprecated reshape2::melt() with base R and tidyr equivalents#479
Open
utkarshpawade wants to merge 3 commits intostan-dev:masterfrom
Open
Replace deprecated reshape2::melt() with base R and tidyr equivalents#479utkarshpawade wants to merge 3 commits intostan-dev:masterfrom
utkarshpawade wants to merge 3 commits intostan-dev:masterfrom
Conversation
Accept Windows-specific rendering differences from GitHub Actions CI.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 98.66% 98.55% -0.12%
==========================================
Files 35 35
Lines 5860 5888 +28
==========================================
+ Hits 5782 5803 +21
- Misses 78 85 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jgabry The 10 uncovered lines are in R/bayesplot-extractors.R, specifically the log_posterior.CmdStanMCMC and nuts_params.CmdStanMCMC methods which require a CmdStan installation to test. These lines were already uncovered before this PR, I just replaced uncovered reshape2 code with equivalent uncovered base R code. No regression in coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #478
Summary
reshape2::melt()across 5 source files withbase::as.data.frame.table(),tidyr::pivot_longer(), and explicitdplyr::bind_rows()constructionsreshape2fromDESCRIPTIONImports — it is no longer neededppd_statplots affected by the migrationreshape2::melt()