Testing clang_tidy error style check

[m-olko]

This PR

• adds this new feature

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

[gemini-code-assist]

Summary of Changes

Hello @m-olko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing code quality enforcement by configuring clang-tidy to treat all warnings as errors, which will lead to stricter checks in the CI/CD pipeline. Additionally, it includes a minor cleanup in the Bazel build configuration by removing an obsolete flag and a small code formatting fix to ensure proper file termination.

Highlights

• Clang-Tidy Configuration: Configured clang-tidy to treat all warnings as errors, enforcing stricter code quality checks and preventing builds with warnings.
• Build Configuration Cleanup: Removed an outdated or unnecessary build --features=-parse_headers flag and its associated comments from the .bazelrc file, streamlining the build configuration.
• Code Formatting: Addressed a missing newline at the end of the openfeature/evaluation_context.h file, ensuring consistent file formatting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables treating clang-tidy warnings as errors, which is a positive change for code quality. I've identified one change that will likely cause a build failure under these new stricter settings—the removal of a newline at the end of a header file. A specific comment with a fix has been provided.