Skip to content

fix(transport): call onerror for silently swallowed parse errors #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nielskaspers wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix(transport): call onerror for silently swallowed parse errors #1626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac0a1e6
fix(transport): call onerror for silently swallowed parse errors
nielskaspers Mar 4, 2026
d7e63d2
Merge branch 'main' into fix/1395-transport-onerror-silent-swallow
KKonstantinov Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/server/src/server/streamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
if (options?.parsedBody === undefined) {
try {
rawMessage = await req.json();
} catch {
} catch (parseError) {
this.onerror?.(parseError as Error);
return this.createJsonErrorResponse(400, -32_700, 'Parse error: Invalid JSON');
}
} else {
Expand All @@ -649,7 +650,8 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
messages = Array.isArray(rawMessage)
? rawMessage.map(msg => JSONRPCMessageSchema.parse(msg))
: [JSONRPCMessageSchema.parse(rawMessage)];
} catch {
} catch (parseError) {
this.onerror?.(parseError as Error);
return this.createJsonErrorResponse(400, -32_700, 'Parse error: Invalid JSON-RPC message');
}

Expand Down
Loading