fix(transport): call onerror for silently swallowed parse errors#1626
Open
nielskaspers wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix(transport): call onerror for silently swallowed parse errors#1626nielskaspers wants to merge 2 commits intomodelcontextprotocol:mainfrom
nielskaspers wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Several nested try/catch blocks in StreamableHTTPServerTransport.handlePostRequest returned error responses without calling the onerror callback, making it impossible to observe or log those errors. Add onerror calls before returning 400 responses for invalid JSON and invalid JSON-RPC message parse failures, consistent with the outer catch block that already calls onerror. Fixes modelcontextprotocol#1395
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1395
Several nested
try/catchblocks insideStreamableHTTPServerTransport.handlePostRequestwere returning 400 error responses without calling theonerrorcallback. This made those errors completely invisible to server authors who rely ontransport.onerrorfor logging and observability.Affected paths (before this fix):
req.json()throws) → returned 400,onerrornever calledJSONRPCMessageSchema.parsethrows) → returned 400,onerrornever calledThe outer
catchat the end ofhandlePostRequestalready correctly callsthis.onerror?.(error as Error), so this change makes the nested catches consistent with that pattern.Changes
packages/server/src/server/streamableHttp.ts: capture the error in two nestedcatchblocks and callthis.onerror?.(parseError as Error)before returning the JSON error responseTest plan
onerrorhandler to aStreamableHTTPServerTransportand send a request with a malformed JSON body — the handler should now fire