fix: count only unique test results during simulation flow result count aggregations#126
Open
AlexJones0 wants to merge 1 commit intolowRISC:masterfrom
Open
fix: count only unique test results during simulation flow result count aggregations#126AlexJones0 wants to merge 1 commit intolowRISC:masterfrom
AlexJones0 wants to merge 1 commit intolowRISC:masterfrom
Conversation
Fix the aggregation logic for the number of tests passed and in total. A single test result can appear in many different Testpoints across a stage, and likewise in many different stages across the entire Testplan. But it should only be counted once per stage and once globally. That is to say, that the counts should always reflect the actual number of underlying unique tests run by the scheduler. Aside: this isn't the cleanest addition, as this whole test result computation logic could use some refactoring and cleanup (especially with the legacy Testplan object that it somewhat duplicates), but for now the priority is on fixing this and getting it working. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
machshev
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the seventh of a series of PRs to rewrite DVSim's core scheduling functionality (Scheduler, status display, launchers / runtime backends) to use an async design, with key goals of long term maintainability and extensibility.
This PR contains an independent/unrelated fix for the generated output results that were hindering comparisons with the original DVSim checked into OpenTitan. A single test result can appear in many different testpoints across a stage, and likewise in many different stages across the entire testplan. But, it should really only be counted once per stage and once globally when aggregating - that is, the counts should always reflect the actual number of unique underlying tests run by the scheduler.
Aside: this isn't the most clean addition, as this whole test result computation logic could use some refactoring and cleanup (especially with the legacy
Testplanobject that it somewhat duplicates), but for now the priority is on fixing this and getting it working.