fix: restore RunTest simulation time parsing#125
Open
AlexJones0 wants to merge 2 commits intolowRISC:masterfrom
Open
fix: restore RunTest simulation time parsing#125AlexJones0 wants to merge 2 commits intolowRISC:masterfrom
AlexJones0 wants to merge 2 commits intolowRISC:masterfrom
Conversation
See e.g. the G004 logging-f-string Ruff lint. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
This functionality was accidentally removed in `596d92f`, meaning that tests no longer reported any simulated time values that were parsed from their logs. Reintroduce this functionality via the existing plugins to mimic the original DVSim functionality. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
machshev
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the sixth of a series of PRs to rewrite DVSim's core scheduling functionality (Scheduler, status display, launchers / runtime backends) to use an async design, with key goals of long term maintainability and extensibility.
This PR contains a fix to the
LocalLauncherwhich will be later be incorporated into the newly introduced equivalent async backend. It fixes functionality was accidentally removed in 596d92f, meaning that tests no longer reported any simulated time values that were parsed from their logs. This PR reintroduces this functionality via the existing plugins to mimic the original DVSim functionality.