Fix EnlightenStatusPrinter leaving the terminal in a bad state & improve the running job display#124
Merged
AlexJones0 merged 2 commits intolowRISC:masterfrom Mar 27, 2026
Conversation
AlexJones0
changed the title
EnlightenStatusPrinter leaving the terminal in a bad state & improve the running job displayEnlightenStatusPrinter leaving the terminal in a bad state & improve the running job display
rswarbrick
approved these changes
Mar 27, 2026
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Nitty comment, but this looks good to me.
See the relevant comments; a SIGINT (Ctrl-C) can seemingly cause Enlighten / Blessed to not properly restore the terminal attributes correctly. So, after stopping the manager, always restore them manually in case we exited this way to be sure that the terminal continues to function properly. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
A small bit of refactoring on the status printer, plus fixing an incorrect type, and then implement functionality using `shutil` to get the width of the terminal, and then truncate the list of running jobs only up to the end of the terminal. This makes better use of the terminal width that we do have, and lets us display more running jobs at once. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
enlighten_status_fixes
branch
from
452bf04 to
40233fc
Compare
machshev
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the fifth of a series of PRs to rewrite DVSim's core scheduling functionality (Scheduler, status display, launchers / runtime backends) to use an async design, with key goals of long term maintainability and extensibility.
This PR contains a fix to the
EnlightenStatusPrinterthat will later be incorporated into the new async status printer. It fixes a bug where a SIGINT (Ctrl-C) can seemingly cause Enlighten / Blessed to not properly restore the terminal attributes correctly (ECHO/ICANON), leading the terminal to appear frozen. This PR ensures we always restore these attributes where possible so that the terminal continues to function properly.It also contains a small improvement to the display of running jobs for each target: rather than strictly truncating at 28-30 characters, it tries to expand and fill the entire terminal width where possible, so that we can see the information about more running jobs at one time.
See the commit messages for more information.