fix: tee interactive job stdout/stderr to the log file#123
Merged
AlexJones0 merged 2 commits intolowRISC:masterfrom Mar 30, 2026
Merged
fix: tee interactive job stdout/stderr to the log file#123AlexJones0 merged 2 commits intolowRISC:masterfrom
AlexJones0 merged 2 commits intolowRISC:masterfrom
Conversation
This attribute does not need to be part of the `JobSpec`, it was only inherited because it was originally on a part of the `Deploy` that was being used by the launcher. This attribute is only used in the `Local` and `nc` launchers to determine whether to apply the timeout or not. But given that the timeout is only used in these instances, it suffices to instead remove the timeout for jobs that would previously have had this attribute. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
rswarbrick
reviewed
Mar 27, 2026
machshev
approved these changes
Mar 27, 2026
Currently, interactive jobs with pass/fail regex patterns will always fail because no logs are created for jobs run interactively. For the local launcher, we add some additional subprocess piping logic to tee the stdout/stderr contents to the log file so that the standard `_check_status` logic can run as normal. Aside: this logic can be cleaned up somewhat, but the main aim of this commit is fixing the bug, as it is intended that this local launcher will be replaced entirely in the future and this code will be removed. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
tee_interactive
branch
from
0ceb31d to
dc81f2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the fourth of a series of PRs to rewrite DVSim's core scheduling functionality (Scheduler, status display, launchers / runtime backends) to use an async design, with key goals of long term maintainability and extensibility.
This PR just contains an unrelated fix found during the rewrite process. Currently, interactive jobs with pass/fail regex patterns will always fail because no logs are created for jobs that are run interactively. For the local launcher, this PR adds some additional subprocess piping logic to tee the stdout/stderr contents to the log file, so that the standard
_check_statuslogic can run as normal. It also does a small refactor on theJobSpecand launchers.See the commit messages for more information.