Skip to content

fix: correct incorrectly nested tests in object_test.ts#2798

Merged
brendandburns merged 2 commits intomax-regen-genfrom
copilot/sub-pr-2770-another-one
Mar 17, 2026
Merged

fix: correct incorrectly nested tests in object_test.ts#2798
brendandburns merged 2 commits intomax-regen-genfrom
copilot/sub-pr-2770-another-one

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

Three tests in src/object_test.ts were accidentally nested inside the body of it('should read a resource', ...) after its finally block, causing them to be registered as sub-tests that the Node.js test runner cancelled when the parent completed.

Changes

  • src/object_test.ts: Close it('should read a resource', ...) after its finally block; move the three orphaned it() calls to the correct outer scope with proper indentation:
    • should read a custom resource
    • should list resources in a namespace
    • should list resources in all namespaces

Before (broken structure):

it('should read a resource', async () => {
    // ...
    } finally { ... }

    it('should read a custom resource', ...)  // nested — never runs
    it('should list resources in a namespace', ...)
    it('should list resources in all namespaces', ...)
});

After:

it('should read a resource', async () => {
    // ...
    } finally { ... }
});

it('should read a custom resource', ...)  // correct scope
it('should list resources in a namespace', ...)
it('should list resources in all namespaces', ...)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI mentioned this pull request Mar 17, 2026
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2026
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2026
Copilot AI changed the title [WIP] Chore: Regenerate with new openapi generator fix: correct incorrectly nested tests in object_test.ts Mar 17, 2026
Copilot AI requested a review from brendandburns March 17, 2026 23:54
@brendandburns brendandburns marked this pull request as ready for review March 17, 2026 23:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026
@brendandburns brendandburns merged commit 596aedf into max-regen-gen Mar 17, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants