chore: regenerate

[mstruebing]

This regenerates the with the new openapi generator after the changes from #2738

The code needs to be adjusted the generator now works wit undici.
Help would be appreciated, I've tried it two times but always went into deep rabbit holes.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mstruebing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidgamero]

i started on this too, im working on the nock testing bit as undici fetch uses mocks instead

socks proxy was a rabbithole too i havent found a solution for that yet

[Rezrazi]

@mstruebing @davidgamero I tried to give it a go, however many apis use "fetch" directly, instead of using the same "configuration" pattern in other regular APIs.

Would you prefer if the APIs are to be rewritten to match the same pattern? in the spirit of my previous PR updating watch_api?

I think if all APIs are aligned, it would be easier to update to undici, but it will most definitely be a breaking change

[Rezrazi]

these apis currently use fetch() directly

• src/health.ts
• src/log.ts
• src/metrics.ts
• src/watch.ts

[brendandburns]

@copilot please fix this PR

[Copilot]

@brendandburns I've opened a new pull request, #2794, to work on those changes. Once the pull request is ready, I'll request review from you.

[brendandburns]

I tried a copilot fix for this which is now applied, it modifies a bunch of the tests, I did some manual verification, but would love a second pair of eyes.

[brendandburns]

@copilot please fix tests, looks like File is not defined? Maybe this is a nodejs 18 thing?

[Copilot]

@brendandburns I've opened a new pull request, #2797, to work on those changes. Once the pull request is ready, I'll request review from you.

[brendandburns]

@copilot please fix the remaining 3 failing tests.

[brendandburns]

@copilot can you address the comments wrt to the finally block?

@cjihrig I think that socks proxy support is still there, since there is now a unit test for the SoxyProxyAgent showing up but if we get to the point of creating an undici dispatcher, which is HTTP, and the proxy is SOCKS, it will error out. This should really never happen. (at least that's my reading of the code)

[Copilot]

@brendandburns I've opened a new pull request, #2800, to work on those changes. Once the pull request is ready, I'll request review from you.

[davidgamero]

i echo the previous comments on private state extraction of symbols @cjihrig
as many of these tests are essentially validating args to the UndiciAgent | UndiciProxyAgent constructors,

proposal to extract a createDispatcherOptions method from createDispatcher that shares a parameter signature ex:

private createDispatcherOptions(
  cluster: Cluster | null,
  agentOptions: https.AgentOptions
): UndiciAgentOptions | UndiciProxyAgentOptions 

we can test that method directly, and the createDispatcher function serves to pass those options to constructors exclusively.
this would remove the need for much of the fragile introspection

[davidgamero]

@copilot try out the idea to extract a createDispatcherOptions method in a PR and note if it can effectively reduce reliance on symbol internals by testing the options generation instead of the objects post-constructor invocation:

proposal to extract a createDispatcherOptions method from createDispatcher that shares a parameter signature ex:

private createDispatcherOptions(
  cluster: Cluster | null,
  agentOptions: https.AgentOptions
): UndiciAgentOptions | UndiciProxyAgentOptions 

we can test that method directly, and the createDispatcher function serves to pass those options to >constructors exclusively.

[davidgamero]

made a PR into this branch for the options extraction here #2801

[brendandburns]

@copilot please fix tests again, looks like the undici version got moved to version 7 again and it should be version 6

[Copilot]

@brendandburns I've opened a new pull request, #2802, to work on those changes. Once the pull request is ready, I'll request review from you.

[davidgamero]

small format fix that's blocking the tests #2806