fix!: Fix pagination support for IssuesService list methods

.golangci.yml

@@ -287,11 +287,6 @@ linters:
             - IssueListByRepoOptions.Sort # TODO: Issues
             - IssueListByRepoOptions.Sort # TODO: Issues
             - IssueListByRepoOptions.State # TODO: Issues
-            - IssueListOptions.Direction # TODO: Issues
-            - IssueListOptions.Filter # TODO: Issues
-            - IssueListOptions.Since # TODO: Issues
-            - IssueListOptions.Sort # TODO: Issues
-            - IssueListOptions.State # TODO: Issues
             - IssueRequest.Assignees # TODO: Issues
             - IssueRequest.Labels # TODO: Issues
             - License.Conditions # TODO: Licenses

github/issues.go

@@ -105,25 +105,25 @@ type IssueRequest struct {
 type IssueListOptions struct {
 	// Filter specifies which issues to list. Possible values are: assigned,
 	// created, mentioned, subscribed, all. Default is "assigned".
-	Filter string `url:"filter,omitempty"`
+	Filter *string `url:"filter,omitempty"`
 
 	// State filters issues based on their state. Possible values are: open,
 	// closed, all. Default is "open".
-	State string `url:"state,omitempty"`
+	State *string `url:"state,omitempty"`
 
 	// Labels filters issues based on their label.
 	Labels []string `url:"labels,comma,omitempty"`
 
 	// Sort specifies how to sort issues. Possible values are: created, updated,
 	// and comments. Default value is "created".
-	Sort string `url:"sort,omitempty"`
+	Sort *string `url:"sort,omitempty"`
 
 	// Direction in which to sort issues. Possible values are: asc, desc.
 	// Default is "desc".
-	Direction string `url:"direction,omitempty"`
+	Direction *string `url:"direction,omitempty"`
 
 	// Since filters issues by time.
-	Since time.Time `url:"since,omitempty"`
+	Since *time.Time `url:"since,omitempty"`
 
 	ListCursorOptions
 
@@ -245,11 +245,8 @@ type IssueListByRepoOptions struct {
 	// Since filters issues by time.
 	Since time.Time `url:"since,omitempty"`
 
+	// ListCursorOptions specifies the optional parameters for cursor pagination.
 	ListCursorOptions
-
-	// Add ListOptions so offset pagination with integer type "page" query parameter is accepted
-	// since ListCursorOptions accepts "page" as string only.
-	ListOptions
 }
 
 // ListByRepo lists the issues for the specified repository.

github/issues_test.go

@@ -28,22 +28,21 @@ func TestIssuesService_List_all(t *testing.T) {
 			"labels":    "a,b",
 			"sort":      "updated",
 			"direction": "asc",
-			"since":     "2002-02-10T15:30:00Z",
+			"since":     referenceTime.Format(time.RFC3339),
 			"page":      "1",
 			"per_page":  "2",
-			"before":    "foo",
-			"after":     "bar",
 		})
 		fmt.Fprint(w, `[{"number":1}]`)
 	})
 
 	opt := &IssueListOptions{
-		"all", "closed",
-		[]string{"a", "b"},
-		"updated", "asc",
-		time.Date(2002, time.February, 10, 15, 30, 0, 0, time.UTC),
-		ListCursorOptions{Before: "foo", After: "bar"},
-		ListOptions{Page: 1, PerPage: 2},
+		Filter:      Ptr("all"),
+		State:       Ptr("closed"),
+		Labels:      []string{"a", "b"},
+		Sort:        Ptr("updated"),
+		Direction:   Ptr("asc"),
+		Since:       Ptr(referenceTime),
+		ListOptions: ListOptions{Page: 1, PerPage: 2},
 	}
 	ctx := t.Context()
 	issues, _, err := client.Issues.List(ctx, true, opt)
@@ -158,22 +157,26 @@ func TestIssuesService_ListByRepo(t *testing.T) {
 			"labels":    "a,b",
 			"sort":      "updated",
 			"direction": "asc",
-			"since":     "2002-02-10T15:30:00Z",
+			"since":     referenceTime.Format(time.RFC3339),
 			"per_page":  "1",
-			"before":    "foo",
-			"after":     "bar",
 		})
 		fmt.Fprint(w, `[{"number":1}]`)
 	})
 
+	// IssueListByRepoOptions uses standard strings (not pointers) and ListCursorOptions
 	opt := &IssueListByRepoOptions{
-		"*", "closed", "a", "c", "m",
-		[]string{"a", "b"},
-		"updated", "asc",
-		time.Date(2002, time.February, 10, 15, 30, 0, 0, time.UTC),
-		ListCursorOptions{PerPage: 1, Before: "foo", After: "bar"},
-		ListOptions{0, 0},
+		Milestone:         "*",
+		State:             "closed",
+		Assignee:          "a",
+		Creator:           "c",
+		Mentioned:         "m",
+		Labels:            []string{"a", "b"},
+		Sort:              "updated",
+		Direction:         "asc",
+		Since:             referenceTime,
+		ListCursorOptions: ListCursorOptions{PerPage: 1},
 	}
+
 	ctx := t.Context()
 	issues, _, err := client.Issues.ListByRepo(ctx, "o", "r", opt)
 	if err != nil {