fix!: Fix pagination support for IssuesService list methods

[maishivamhoo123]

BREAKING CHANGE: ListCursorOptions is removed from IssuesService.List and IssuesService.ListByRepo.

Updates: #3976.

Removed unsupported cursor pagination IssuesService.List and IssuesService.ListByRepo by deleting ListCursorOptions from issue option structs. Updated related unit tests accordingly.

[maishivamhoo123]

@gmlewis, @alexandear and @Not-Dhananjay-Mishra can you please review this PR?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (e5024aa) to head (5ba7d6c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3984      +/-   ##
==========================================
- Coverage   93.53%   93.53%   -0.01%     
==========================================
  Files         207      207              
  Lines       17610    17606       -4     
==========================================
- Hits        16471    16467       -4     
  Misses        938      938              
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

Thank you, @maishivamhoo123!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra

[Not-Dhananjay-Mishra]

Also SubIssueService.ListByIssue ( Point 3 in #3976 ) also accepts IssueListOptions as one of the parameters so we can also include that in BREAKING CHANGE description

[Not-Dhananjay-Mishra]

Since we are updating this struct, How about using * with omitempty fields to be consistent with rest of the repo.

	Filter    *string    `url:"filter,omitempty"`
	State     *string    `url:"state,omitempty"`
	Labels    []string  `url:"labels,comma,omitempty"`
	Sort      *string    `url:"sort,omitempty"`
	Direction *string    `url:"direction,omitempty"`
	Since     *time.Time `url:"since,omitempty"`

After updating please remove these line from .golangci.yml

go-github/.golangci.yml

Lines 290 to 294 in e5024aa

	- IssueListOptions.Direction # TODO: Issues
	- IssueListOptions.Filter # TODO: Issues
	- IssueListOptions.Since # TODO: Issues
	- IssueListOptions.Sort # TODO: Issues
	- IssueListOptions.State # TODO: Issues

[Not-Dhananjay-Mishra]

I apologize for not trying IssuesService.ListByRepo endpoint manually previously. It supports cursor based pagination, so we can undo these changes.
Also, I tried IssuesService.List it works perfectly fine for me with page=100 and per_page=100. But I am not assigned to many issues so someone else please try and verify.