Skip to content

Make S3 checksum settings configurable via JSON config #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serdarozerr wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Open

Make S3 checksum settings configurable via JSON config #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4b687
feat: checksum parameters are converted to be configurable
serdarozerr Apr 2, 2026
341135e
fix: formatting is fixed
serdarozerr Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion s3/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ The S3 client requires a JSON configuration file with the following structure:
"upload_part_size": <int64> (optional - default: 5242880), # 5 MB
"multipart_copy_threshold": <int64> (optional - default: 5368709120), # 5 GB - files larger than this use multipart copy
"multipart_copy_part_size": <int64> (optional - default: 104857600), # 100 MB - must be at least 5 MB
"single_upload_threshold": <int64> (optional - default: 0) # bytes; files <= this use a single PutObject call, larger files use multipart upload. 0 means always use multipart. Max 5 GB for AWS S3. GCS ignores this and always uses single upload.
"single_upload_threshold": <int64> (optional - default: 0), # bytes; files <= this use a single PutObject call, larger files use multipart upload. 0 means always use multipart. Max 5 GB for AWS S3. GCS ignores this and always uses single upload.
"request_checksum_calculation_enabled": <bool> (optional - default: true),
"response_checksum_calculation_enabled": <bool> (optional - default: true),
"uploader_request_checksum_calculation_enabled": <bool> (optional - default: true)
}
```

Expand Down
6 changes: 3 additions & 3 deletions s3/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ type S3Cli struct {
HostStyle bool `json:"host_style"`
SwiftAuthAccount string `json:"swift_auth_account"`
SwiftTempURLKey string `json:"swift_temp_url_key"`
RequestChecksumCalculationEnabled bool
ResponseChecksumCalculationEnabled bool
UploaderRequestChecksumCalculationEnabled bool
RequestChecksumCalculationEnabled bool `json:"request_checksum_calculation_enabled"`
ResponseChecksumCalculationEnabled bool `json:"response_checksum_calculation_enabled"`
UploaderRequestChecksumCalculationEnabled bool `json:"uploader_request_checksum_calculation_enabled"`
// Optional knobs to tune transfer performance.
// If zero, the client will apply sensible defaults (handled by the S3 client layer).
// Part size values are provided in bytes.
Expand Down
Loading