Skip to content

Make S3 checksum settings configurable via JSON config#81

Open
serdarozerr wants to merge 2 commits intocloudfoundry:mainfrom
sap-contributions:feature/make-s3-checksum-configurable
Open

Make S3 checksum settings configurable via JSON config#81
serdarozerr wants to merge 2 commits intocloudfoundry:mainfrom
sap-contributions:feature/make-s3-checksum-configurable

Conversation

@serdarozerr
Copy link
Copy Markdown
Contributor

Previously, the three S3 checksum calculation flags (RequestChecksumCalculationEnabled, ResponseChecksumCalculationEnabled, UploaderRequestChecksumCalculationEnabled) were hardcoded struct fields with no JSON binding, meaning they could not be set from the config file.

This change adds json struct tags to all three fields, exposing them as optional config parameters:

request_checksum_calculation_enabled (default: true)
response_checksum_calculation_enabled (default: true)
uploader_request_checksum_calculation_enabled (default: true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants