Skip to content

Fix shopify app dev command to show host theme URL #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karreiro wants to merge 1 commit into from
+12 −1
Closed

Fix shopify app dev command to show host theme URL #7156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/vast-teams-shine.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Fix a compatibility issue with Ink theme app extension links in the `shopify app dev` command
8 changes: 7 additions & 1 deletion packages/app/src/cli/services/dev/processes/theme-app-extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {HostThemeManager} from '../../../utilities/extensions/theme/host-theme-m
import {AppInterface} from '../../../models/app/app.js'
import {OrganizationApp} from '../../../models/organization.js'
import {ClientName} from '../../../utilities/developer-platform-client.js'
import {outputDebug} from '@shopify/cli-kit/node/output'
import {outputDebug, outputNewline} from '@shopify/cli-kit/node/output'
import {AdminSession, ensureAuthenticatedAdmin} from '@shopify/cli-kit/node/session'
import {fetchTheme} from '@shopify/cli-kit/node/themes/api'
import {AbortError} from '@shopify/cli-kit/node/error'
Expand Down Expand Up @@ -91,6 +91,12 @@ export async function setupPreviewThemeAppExtensionsProcess(
],
})

/*
* This line is a workaround for the recent Ink upgrade that consumes the last
* line from the terminal.
*/
outputNewline()

return {
type: 'theme-app-extensions',
prefix: 'theme-extensions',
Expand Down
Loading