Skip to content

Fix shopify app dev command to show host theme URL#7156

Closed
karreiro wants to merge 1 commit intomainfrom
app-dev-fix-ink
Closed

Fix shopify app dev command to show host theme URL#7156
karreiro wants to merge 1 commit intomainfrom
app-dev-fix-ink

Conversation

@karreiro
Copy link
Copy Markdown
Contributor

@karreiro karreiro commented Apr 2, 2026

Fix shopify app dev command to show host theme URL.

Why are these changes introduced?

After the Ink upgrade, the last link (in the development server info box) was removed from shopify app dev when running it in an app with theme app extensions. This is a problem because app extension developers can no longer set up their theme app extension in the host theme.

What is this pull request doing?

This PR adds a \n to the host theme link to work around the Ink compatibility issue.

How to test your changes?

Run shopify app dev in an app with a theme app extension.

image

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@karreiro karreiro requested review from a team as code owners April 2, 2026 10:08
Copilot AI review requested due to automatic review settings April 2, 2026 10:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the shopify app dev theme app extension dev process output to restore/adjust the host theme editor link and removes the now-unneeded “install your app” setup link after an Ink upgrade changed banner rendering.

Changes:

  • Remove the “Install your app in your development store” next-step (and its URL-building logic) from the theme app extension dev server info banner.
  • Adjust the host theme editor link output to work around an Ink compatibility issue by appending a newline.
  • Add a changeset for the @shopify/app patch release and update unit test expectations (partially).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/app/src/cli/services/dev/processes/theme-app-extension.ts Removes app install link generation and alters the host theme editor URL output.
packages/app/src/cli/services/dev/processes/theme-app-extension.test.ts Updates one renderInfo assertion to match the new banner output.
.changeset/vast-teams-shine.md Adds release note entry for the change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@isaacroldan
Copy link
Copy Markdown
Contributor

/snapit

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260402103028

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@karreiro
Copy link
Copy Markdown
Contributor Author

karreiro commented Apr 2, 2026

Closing in favor of the handling issue at Ink wrapper level.

@karreiro karreiro closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants