Fix shopify app dev command to show host theme URL#7156
Fix shopify app dev command to show host theme URL#7156
shopify app dev command to show host theme URL#7156Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the shopify app dev theme app extension dev process output to restore/adjust the host theme editor link and removes the now-unneeded “install your app” setup link after an Ink upgrade changed banner rendering.
Changes:
- Remove the “Install your app in your development store” next-step (and its URL-building logic) from the theme app extension dev server info banner.
- Adjust the host theme editor link output to work around an Ink compatibility issue by appending a newline.
- Add a changeset for the
@shopify/apppatch release and update unit test expectations (partially).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/app/src/cli/services/dev/processes/theme-app-extension.ts | Removes app install link generation and alters the host theme editor URL output. |
| packages/app/src/cli/services/dev/processes/theme-app-extension.test.ts | Updates one renderInfo assertion to match the new banner output. |
| .changeset/vast-teams-shine.md | Adds release note entry for the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/app/src/cli/services/dev/processes/theme-app-extension.ts
Outdated
Show resolved
Hide resolved
packages/app/src/cli/services/dev/processes/theme-app-extension.test.ts
Outdated
Show resolved
Hide resolved
65a01ad to
401ac7b
Compare
…shopify app dev` command
401ac7b to
5098d2b
Compare
|
/snapit |
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260402103028Caution After installing, validate the version by running |
|
Closing in favor of the handling issue at Ink wrapper level. |
Fix
shopify app devcommand to show host theme URL.Why are these changes introduced?
After the Ink upgrade, the last link (in the development server info box) was removed from
shopify app devwhen running it in an app with theme app extensions. This is a problem because app extension developers can no longer set up their theme app extension in the host theme.What is this pull request doing?
This PR adds a
\nto the host theme link to work around the Ink compatibility issue.How to test your changes?
Run
shopify app devin an app with a theme app extension.Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist