Skip to content

Add helpful markers/comments in :empty #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngie-eign wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add helpful markers/comments in :empty #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions tests/fs/tmpfs/t_times.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,17 @@ empty_head() {
empty_body() {
test_mount

atf_check -s exit:0 -o empty -e empty touch a
local file=a

# NB: this should not be required unless someone ran the script
# directly or used `kyua debug`.
rm -f $file

# All atime/ctime/mtime should equal st_birthtime since the file
# was just created.
echo "1. Creation"

atf_check -s exit:0 -o empty -e empty touch $file
eval $(stat -s a | sed -e 's|st_|ost_|g') || atf_fail "stat failed"
[ ${ost_birthtime} -eq ${ost_atime} ] || \
atf_fail "Incorrect atime: ${ost_birthtime} != ${ost_atime}"
Expand All @@ -47,8 +57,11 @@ empty_body() {
[ ${ost_birthtime} -eq ${ost_mtime} ] || \
atf_fail "Incorrect mtime: ${ost_birthtime} != ${ost_mtime}"

# 2. atime should be updated; all else should remain constant
echo "2. Read"

sleep 1
atf_check -s exit:0 -o empty -e empty cat a
atf_check -s exit:0 -o empty -e empty cat $file
eval $(stat -s a) || atf_fail "stat failed"
[ ${st_atime} -gt ${ost_atime} ] || \
atf_fail "Incorrect atime: ${st_atime} <= ${ost_atime}"
Expand All @@ -57,8 +70,13 @@ empty_body() {
[ ${st_mtime} -eq ${ost_mtime} ] || \
atf_fail "Incorrect mtime: ${st_mtime} != ${ost_mtime}"

# 3. atime/ctime/mtime should be updated.
#
# Technically birthtime should be updated too.
echo "3. Truncation"

sleep 1
echo foo >a || atf_fail "Write failed"
echo foo >$file || atf_fail "Write failed"
eval $(stat -s a) || atf_fail "stat failed"
[ ${st_atime} -gt ${ost_atime} ] || \
atf_fail "Incorrect atime: ${st_atime} <= ${ost_atime}"
Expand Down