Open
Conversation
It's difficult determining which steps failed without appropriate markers since some of the commands called do not use `atf_check`. Adding markers with `echo` provides test documentation and helps distinguish which portion of the file failed without resorting to decorating all of the `atf_fail` calls with unique "identifiers". Add comments around the testcases as well to help document what the test is asserting and why it's asserting that. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's difficult determining which steps failed without appropriate markers since some of the commands called do not use
atf_check. Adding markers withechoprovides test documentation and helps distinguish which portion of the file failed without resorting to decorating all of theatf_failcalls with unique "identifiers".Add comments around the testcases as well to help document what the test is asserting and why it's asserting that.