Skip to content

feat: add compact call_data length prefix to unsigned signing payload #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcovar merged 1 commit into from
Mar 20, 2026
Merged

feat: add compact call_data length prefix to unsigned signing payload #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/wasm-dot/src/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,15 @@ impl Transaction {
// Fall back to manual serialization if no context
self.to_bytes_manual()
} else {
// Unsigned: return the signing payload (call_data + extensions + additional_signed).
// This matches legacy toBroadcastFormat which returns construct.signingPayload().
self.signable_payload()
// Unsigned: return the signing payload with a compact call_data length prefix.
// Format: compact(call_data_len) | call_data | extensions | additional_signed
// This matches legacy toBroadcastFormat (construct.signingPayload from txwrapper)
// and is decodable by both wasm-dot and polkadot-js/txwrapper.
use parity_scale_codec::{Compact, Encode};
let payload = self.signable_payload()?;
let mut result = Compact(self.call_data.len() as u32).encode();
result.extend_from_slice(&payload);
Ok(result)
}
}

Expand Down
Loading