feat: add compact call_data length prefix to unsigned signing payload#224
Merged
feat: add compact call_data length prefix to unsigned signing payload#224
Conversation
Without the prefix, wasm-dot signing payloads can't be decoded by polkadot-js/txwrapper, which expects compact(call_data_len) before the call data. This makes wasm-dot a drop-in replacement for the legacy builder in any code path that uses TransactionBuilderFactory.from(). signablePayload() (used for signature generation) is unchanged. BTC-3198
lcovar
force-pushed
the
BTC-3198/compact-prefix-in-unsigned
branch
from
ab93312 to
d45d3dc
Compare
davidkaplanbitgo
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the prefix, wasm-dot signing payloads can't be decoded by
polkadot-js/txwrapper, which expects compact(call_data_len) before
the call data. This makes wasm-dot a drop-in replacement for the
legacy builder in any code path that uses TransactionBuilderFactory.from().
signablePayload() (used for signature generation) is unchanged.
BTC-3198