Conversation
Benchmark - coreYew MasterPull Request |
|
Visit the preview URL for this PR (updated for commit d084850): https://yew-rs--pr3937-fix-typos-195b5yc9.web.app (expires Mon, 24 Nov 2025 19:52:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
WorldSEnder
left a comment
There was a problem hiding this comment.
Looks good, catches a nice number of typos.
Note that we have some spell checking in ci for markdown documents as a stopgap which relies on a custom dictionary.
Did you run into any false positives and if so, is there a way to disable that for (brand) names and similar?
Thanks typos[1]! [1] https://github.com/crate-ci/typos
It makes typos ignore two syllabes files, and one non-typo in a file.
This works on all files instead of just the Markdown files, and already found many issues aspell missed.
I’ve now replaced this CI pass with a typos pass, to catch issues in all files instead of just Markdown ones, and removed the aspell shell script.
Only "Noo" and "ba", I’ve replaced the first one with "Nooo" to accentuate the effect, and ignored the second. The other false positives are from the syllables.txt files in examples, I’ve ignored the files themselves. |
Description
This fixes a bunch of typos found by the typos tool.
Would it make sense to add it to the CI in a future PR, to prevent further typos from being added?
Checklist
Edit: they do pass, but only with
--features=ssr, otherwiseyew::LocalServerRendererisn’t present and packages/yew/tests/raw_html.rs:51 tries to use it anyway.