Conversation
|
enabling pyright seems to create a lot of issues that are quite hard to trace. I am not certain whether these checks actually have been ran with the intent of fixing in the original repository. A lot of the issues are due to the use of @thewtex any thoughts? |
|
Use of pre-commit is a wonderful step forward. If pyright is too big of a jump now, an issue could be created and the current progress merged. |
|
We can also enable the pre-commit bot which i find is a pretty nice UI for the pre-commit errors keeping them visually separate from the tests and it will auto push fixes which can be a ncie help to new contributors who don't want to set up pre-commit |
I think I just have enabled it now. |
|
in it goes. |
closes #6
Draft PR replacing current linters, typecheckers and formattters with pre-commit and fixing outstanding issues related to those. Also add pre-commit github workflow.
cc @ianhi