Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
python: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: astral-sh/setup-uv@eac588ad8def6316056a12d4907a9d4d84ff7a3b # v7.3.0
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # 7.6.0
with:
python-version: ${{ matrix.python }}
enable-cache: true
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
python: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: astral-sh/setup-uv@eac588ad8def6316056a12d4907a9d4d84ff7a3b # v7.3.0
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # 7.6.0
with:
python-version: ${{ matrix.python }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: Run release-please
id: release
uses: googleapis/release-please-action@7987652d64b4581673a76e33ad5e98e3dd56832f # v4.2.0
uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # 4.4.0
with:
token: ${{ steps.generate-token.outputs.token }}

Expand All @@ -40,7 +40,7 @@ jobs:

- name: Install uv
if: steps.release.outputs.prs_created == 'true'
uses: astral-sh/setup-uv@eac588ad8def6316056a12d4907a9d4d84ff7a3b # v7.3.0
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # 7.6.0

- name: Update lockfile
if: steps.release.outputs.prs_created == 'true'
Expand All @@ -64,7 +64,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Install uv
uses: astral-sh/setup-uv@eac588ad8def6316056a12d4907a9d4d84ff7a3b # v7.3.0
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # 7.6.0

- name: Build
run: uv build
Expand Down
10 changes: 5 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ dev = [
{ include-group = "nox" },
]
test = [
"pytest==8.3.4",
"pytest-asyncio==0.23.8",
"pytest==8.4.2",
"pytest-asyncio==0.26.0",
Comment on lines +31 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest 8.4 dropped Python 3.8 support

pytest 8.4.0 removed support for Python 3.8. This project still declares requires-python = ">=3.8" and the CI matrix in ci.yml includes Python 3.8. This upgrade will break the Python 3.8 CI job.

Similarly, pytest-asyncio==0.26.0 has a minimum pytest version of 8.2.0, so this combination will also not work on Python 3.8 where pytest 8.4 cannot be installed.

Either pin these dev dependencies to versions that still support Python 3.8 (e.g., pytest<8.4), or drop Python 3.8 from the project's supported versions and CI matrix.

"pytest-cov==5.0.0",
"six==1.17.0",
]
lint = ["ruff==0.14.5"]
type_check = ["mypy==1.14.1"]
lint = ["ruff==0.15.6"]
type_check = ["mypy==1.19.1"]
nox = [
"nox>=2024.10.9 ; python_version >= '3.9'",
"nox-uv>=0.7.0 ; python_version >= '3.9'",
Expand Down Expand Up @@ -64,5 +64,5 @@ source-include = ["py.typed"]
source-exclude = ["tests*"]

[build-system]
requires = ["uv_build>=0.8.15,<0.9.0"]
requires = ["uv_build>=0.10.10,<0.11.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv.lock not updated alongside pyproject.toml

The lockfile still references the old dependency versions (pytest 8.3.4, pytest-asyncio 0.23.8, mypy 1.14.1, ruff 0.14.5). The CI workflow runs uv sync --locked --dev which will fail if the lockfile doesn't match pyproject.toml. The lockfile needs to be regenerated with uv lock to reflect these version changes.

build-backend = "uv_build"
Loading