Open
Conversation
- Swap prettier for oxfmt (formatter) and oxlint (linter) - Add .oxfmtrc.json and .oxlintrc.json configs - Update CI workflow to run format:check and lint steps - Fix lint warnings: unused params, catch bindings, dead imports
Contributor
Greptile SummaryThis PR replaces Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([Push / Pull Request]) --> B[Install Dependencies]
B --> C[Format Check\npnpm run format:check\noxfmt --check .]
C -->|pass| D[Lint\npnpm run lint\noxlint]
D -->|pass| E[Build\npnpm run build]
E --> F[Test\npnpm run test:coverage]
C -->|fail| X1([❌ CI Fails])
D -->|fail| X2([❌ CI Fails])
E -->|fail| X3([❌ CI Fails])
F -->|fail| X4([❌ CI Fails])
F -->|pass| G([✅ CI Passes])
Last reviewed commit: 4669f6e |
gjtorikian
approved these changes
Mar 11, 2026
| pnpm install | ||
|
|
||
| - name: Prettier | ||
| - name: Format |
Contributor
There was a problem hiding this comment.
Personally, I would split these out into a separate lint.yml, so that the two concerns (bad formatting, failed tests) don't interfere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettierwithoxfmt(formatter) andoxlint(linter) for faster, Rust-based tooling.oxfmtrc.jsonand.oxlintrc.jsonconfig files (same formatting rules as previous prettier config)format:checkand enable the previously commented-outlintstepTest plan
pnpm format:checkpasses (0 issues, 91 files)pnpm lintpasses (0 warnings, 0 errors, 58 files)pnpm testpasses (175 tests)