fix: normalize namespace trailing slash in RESTAPIRepository#421
Merged
fix: normalize namespace trailing slash in RESTAPIRepository#421
Conversation
github-actions
bot
added
the
[Type] Bug
…platforms Ensures namespaces like "sites/123" (without trailing slash) produce the same URLs as "sites/123/" so callers don't need to worry about the convention. Adds tests on both platforms to verify. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jkmassel
force-pushed
the
jkmassel/namespace-trailing-slash
branch
from
02acb23 to
8955bfb
Compare
The mock HTTP client returns empty data, causing JSON decoding errors that prevented the namespace URL assertions from being reached. Since these tests only verify URL construction, try? is appropriate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dcalhoun
approved these changes
Apr 3, 2026
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Looks good aside from the noted test failures.
Comment on lines
+271
to
+273
| _ = try await repository.fetchPost(id: 1) | ||
| _ = try await repository.fetchEditorSettings() | ||
| _ = try await repository.fetchSettingsOptions() |
Member
There was a problem hiding this comment.
These invocations and others in the files caused JSON decoding errors due to the incomplete mock. This caused test and CI task failures. I'm pushed 0222eb3, but feel free to revert or change the approach as desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sites/123) to always include a trailing slash before appending paths inRESTAPIRepositorysites/123posts/1instead ofsites/123/posts/1Extracted from #316.
Test plan
RESTAPIRepositoryTest)RESTAPIRepositoryTests)🤖 Generated with Claude Code