Disallow wildcard partial domains when using MatchDomainName.#9991
Open
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Disallow wildcard partial domains when using MatchDomainName.#9991kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MatchDomainName to reject “partial domain” wildcard patterns in strict left-wildcard matching, aligning behavior with the intended *.domain.com-only rule (fixes zd#21354).
Changes:
- Disallows patterns like
*domain.comwhenleftWildcardOnlyis enabled. - Enforces that the character following the wildcard must be
.(i.e.,*.domain.com).
Comments suppressed due to low confidence (1)
src/internal.c:1
- This check assumes
patternpoints to the character immediately after the*. Ifpatternstill points at the*(or at some other position due to surrounding parsing), this would incorrectly reject all strict-left-wildcard patterns. Consider making the check explicitly reference the character after the wildcard (e.g., using an index/offset relative to the wildcard position) or adjust the code so it unambiguously advances past*before this check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
Retest this please Jenkins. Error during multi-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21354
Testing
Built in tests + provided reproducer.
Checklist