Open
Conversation
Contributor
|
I suspect this was resolved with some nightly multi-test clang tidy fixes merged in today. #9977 |
JacobBarthelmeh
approved these changes
Mar 16, 2026
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Looks like one more that Coverity found vs what was in the clang tidy report. Thanks.
Contributor
Author
|
Was just about to say that. Thanks. |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends prior Coverity-driven hardening to avoid additional potential null dereferences during ECC private key decoding cleanup.
Changes:
- Prevents dereferencing
keywhen freeing ASN.1 get-data state inwc_EccPrivateKeyDecode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds on to #9960, should clear 558861
Testing
./configure --enable-all && make checkChecklist