Fix stack tracking in wolfCrypt benchmark#9983
Open
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix stack tracking in wolfCrypt benchmark#9983Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes stack high-water-mark tracking in the wolfCrypt benchmark so reported stack usage is more accurate on embedded targets, and reduces build warnings by tightening feature-guarded option handling.
Changes:
- Adjust stack checkpointing to measure deltas relative to a baseline and report setup-vs-run stack usage as a peak (MAX) instead of summing.
- Guard
-mac_final/mac_streamunderNO_HMACand-aead_set_key/aead_set_keyunderHAVE_AESGCMto avoid unused-variable warnings. - Change
BENCH_MIN_RUNTIME_SECdefault literal to be explicitlydouble.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Frauschi
force-pushed
the
bench_stack_fix
branch
from
d87e43a to
987a705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stack memory tracking for the wolfCrypt benchmark. Previous numbers have been quite off. Found while obtaining PQC numbers on MCUs.
Also fixes some "unused variable" warnings.
This is, among others, used on the wolfDemo board to show these numbers on trade shows.