autoconf: refresh bundled macros, remove AC_CANONICAL_TARGET#9976
Open
BrianAker wants to merge 2 commits intowolfSSL:masterfrom
Open
autoconf: refresh bundled macros, remove AC_CANONICAL_TARGET#9976BrianAker wants to merge 2 commits intowolfSSL:masterfrom
BrianAker wants to merge 2 commits intowolfSSL:masterfrom
Conversation
This updates bundled autoconf-archive macros, remove AC_CANONICAL_TARGET from configure.ac which had been required because of bug in the version ax_pthread.m4 used. This keeps pthread/configure checks aligned with native host builds and pulls in newer macro behavior for compiler flag probing and compiler version detection.
Member
|
Jenkins retest this please: multi-test bailed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refreshes bundled Autoconf Archive macros and adjusts pthread/configure detection to rely on canonical host (not target), aligning thread checks with native host builds and updated macro behavior.
Changes:
- Update multiple
m4/ax_*macros to newer Autoconf Archive revisions (including license header updates and new compiler/version handling). - Switch
AX_PTHREADto useAC_CANONICAL_HOST/$host_osinstead ofAC_CANONICAL_TARGET/$target_os. - Remove
AC_CANONICAL_TARGETfromconfigure.ac.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| m4/ax_pthread.m4 | Uses canonical host + $host_os for pthread detection; bumps macro serial. |
| m4/ax_create_generic_config.m4 | Macro refresh (header/license/serial). |
| m4/ax_compiler_version.m4 | Macro refresh; adds NVHPC compiler version detection. |
| m4/ax_check_link_flag.m4 | Macro refresh (header/license/serial). |
| m4/ax_check_compile_flag.m4 | Macro refresh; changes compile-flag probing behavior (adds GNU -Werror handling). |
| m4/ax_append_flag.m4 | Macro refresh (header/license/serial). |
| m4/ax_append_compile_flags.m4 | Macro refresh (header/license/serial). |
| configure.ac | Drops AC_CANONICAL_TARGET (no longer needed with updated AX_PTHREAD). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+44
to
+54
| if test x"m4_case(_AC_LANG, | ||
| [C], [$GCC], | ||
| [C++], [$GXX], | ||
| [Fortran], [$GFC], | ||
| [Fortran 77], [$G77], | ||
| [Objective C], [$GOBJC], | ||
| [Objective C++], [$GOBJCXX], | ||
| [no])" = xyes ; then | ||
| add_gnu_werror="-Werror" | ||
| fi | ||
| _AC_LANG_PREFIX[]FLAGS="$[]_AC_LANG_PREFIX[]FLAGS $4 $1 $add_gnu_werror" |
AX_COMPILER_VERSION is inappropriately polluting the compiler options, it also no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates bundled autoconf-archive macros, remove AC_CANONICAL_TARGET from configure.ac which had been required because of bug in the version ax_pthread.m4 used. This keeps pthread/configure checks aligned with native host builds and pulls in newer macro behavior for compiler flag probing and compiler version detection.
To be clear, with the exception of the one line change in configure.ac, all other changes are the updated m4 from autoconf-archive ( brew gives the version as 2024.10.16 ). The autoconf-archive went through a license change sometime ago to the currently used in these files. These m4 were included with wolfssl originally to simplify compiling, which is common for how m4 files are distributed.
Testing
./autogen.sh && ./configure && make && make check && make dist && make distcheck