Fix tls ecdh curve mismatch (wolfTPM build test CI failures)#473
Open
aidangarske wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix tls ecdh curve mismatch (wolfTPM build test CI failures)#473aidangarske wants to merge 1 commit intowolfSSL:masterfrom
aidangarske wants to merge 1 commit intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a CI failure in make test wolfTPM by ensuring TLS ECDHE ephemeral keys are regenerated when TLS key share negotiation changes the selected ECC curve, and by aligning the example TLS test script’s client/server invocations with the intended TLS version parameterization.
Changes:
- Regenerate the TPM-backed ephemeral ECDH key when the negotiated TLS curve differs from the currently loaded key’s curve.
- Update
examples/run_examples.shto pass the requested TLS version (-v $3) to the wolfSSL example server/client and increase the startup delay for the server-side test flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tpm2_cryptocb.c | Detects TLS curve changes and unloads/regenerates the cached TPM ECDH key accordingly. |
| examples/run_examples.sh | Ensures TLS version argument is actually used in wolfSSL example server/client runs; increases wait time for server startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aidangarske
force-pushed
the
fix-tls-ecdh-curve-mismatch
branch
from
7b1f3c7 to
c12ea75
Compare
aidangarske
changed the title
dgarske
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI failure with make test wolfTPM