_dashboard themes: refactor code structure#1032
Open
nicozanf wants to merge 3 commits intoweb2py:masterfrom
Open
_dashboard themes: refactor code structure#1032nicozanf wants to merge 3 commits intoweb2py:masterfrom
nicozanf wants to merge 3 commits intoweb2py:masterfrom
Conversation
Contributor
|
I do not like having different index.html for different color themes. This make is hard to maintain because any change will require editing multiple files. Can this be avoided? |
- index.html is central, use optional partial hooks for single themes styles. - add new Classic theme with separated pages instead of accordion. Should look like the old web2py admin app
Collaborator
Author
|
Right! I have restored index.html centrality - and also added a new Classic theme! Big change. I've tested it quite a lot, but it's mainly AI generated - check it careful and do not hesitate to blame it if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for improved readability and maintainability