feat: drag and drop file paths into terminal #2857
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #746, fixes #2813
You can now drag a file from Finder (or Wave's own file browser) into a terminal block and it drops the quoted path. Been wanting this forever.
How it works:
dragover/dropevent listeners on the terminal's connect elementwebUtils.getPathForFile()through a preload bridge since Electron 32 removedFile.pathgetPathForFileto the preload bridge (preload.ts) and typed it incustom.d.tsNote: since this touches the preload bridge, it requires an app restart (not hot-reloadable).
Test plan