fix: file browser shows newest files first, bump limit to 5000#2856
Draft
JustHereToHelp wants to merge 1 commit intowavetermdev:mainfrom
Draft
fix: file browser shows newest files first, bump limit to 5000#2856JustHereToHelp wants to merge 1 commit intowavetermdev:mainfrom
JustHereToHelp wants to merge 1 commit intowavetermdev:mainfrom
Conversation
Sort directory entries by mtime descending before truncation so the most recent files always appear when a directory exceeds the limit. Bumped MaxDirSize from 1024 to 5000. Uses DirEntry.Info() instead of os.Stat() to avoid extra syscalls. Fixes wavetermdev#2830
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2830
My screenshots folder has about 1300 files and the file browser was just silently cutting off after 1024 — no error, no "load more", just poof. Took me a while to even realize files were missing.
Two changes:
MaxDirSizefrom 1024 to 5000The sort uses
DirEntry.Info()instead ofos.Stat()to avoid the extra syscall overhead on large directories.Test plan