WIP: Add more decorators#1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
===========================================
- Coverage 100% 88.27% -11.73%
===========================================
Files 6 22 +16
Lines 28 145 +117
Branches 5 13 +8
===========================================
+ Hits 28 128 +100
- Misses 0 15 +15
- Partials 0 2 +2
Continue to review full report at Codecov.
|
|
@stevefan1999-personal Thank you so much for the PR! Wow you've done almost everything 👍 Sorry for my late reply. Do you still want to continue with this one? Or should I take over? (since it has been while so, sorry for that) |
|
@kiaking I can still be a contributor |
|
@stevefan1999-personal Great! Thanks. I'll make some comments. |
test/unit/Attribute.spec.ts
Outdated
| describe('Attribute', () => { | ||
| it('can define `attr` field', () => { | ||
| @suite | ||
| export class AttributeSpec { |
There was a problem hiding this comment.
Can we use non-class format for the test? Just to be consistent with Vuex ORM core.
There was a problem hiding this comment.
hmm, but I think it mentally looks better to developers that has adopted to N/JUnit...no?
There was a problem hiding this comment.
Maybe yes, though most of Vue related libraries are written in function way so rather than Class format so 😓 Or I mean I could change this one at my side though.
|
@stevefan1999-personal Thanks a lot! Do you have more to add? If not I'm ready to merge this baby! |
2 participants
vuex-orm/vuex-orm#497