Skip to content

Assert_arrays_eq also executes the array and compares the results against scalar_at#7222

Merged
robert3005 merged 3 commits intodevelopfrom
rk/macroassert
Mar 31, 2026
Merged

Assert_arrays_eq also executes the array and compares the results against scalar_at#7222
robert3005 merged 3 commits intodevelopfrom
rk/macroassert

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

Execute arrays passed to assert_arrays_eq to check any execute_parent rules that
might exist

Signed-off-by: Robert Kruszewski github@robertk.io

…inst scalar_at

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Mar 31, 2026
@robert3005 robert3005 enabled auto-merge (squash) March 31, 2026 16:31
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026

Merging this PR will degrade performance by 16.01%

❌ 1 regressed benchmark
✅ 1105 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 71.6 µs 85.2 µs -16.01%

Comparing rk/macroassert (7e43d02) with develop (5ce08ed)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 merged commit 10c3fc6 into develop Mar 31, 2026
58 of 60 checks passed
@robert3005 robert3005 deleted the rk/macroassert branch March 31, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants