Conversation
f27c320 to
ccff59e
Compare
ccff59e to
1bc107f
Compare
1bc107f to
bc6ab5f
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
0ax1
reviewed
Mar 30, 2026
Contributor
|
worthwhile that @joseph-isaacs has a look who worked a lot with expr in vortex |
0ax1
reviewed
Mar 30, 2026
0ax1
reviewed
Mar 30, 2026
d000145 to
67b5c3c
Compare
a9b51a5 to
9c4e679
Compare
4678def to
3bbdadc
Compare
3bbdadc to
8aabd95
Compare
8aabd95 to
5e8310c
Compare
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com> Signed-off-by: Mikhail Kot <to@myrrc.dev>
5e8310c to
c98aa74
Compare
0ax1
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose a subset of expressions to test filtering in Scan API:
root, get_item, select, or, not, is_null, and binary operators.
Add vx_array_apply to test C-side expression application.
This patch does not include C++ FFI tests because we can't create vx_arrays' yet, #7148.
The next steps are exposing literal expressions and dynamic expressions.
Additional change: Fix sanitizer flags for CI to actually run CI with asan and tsan.