Open
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (4)
Powered by Polar Signals Cloud |
Merging this PR will improve performance by 18.36%
Performance Changes
Comparing 
Footnotes
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: Likely regression (environment too noisy confidence) datafusion / vortex-file-compressed (1.294x ➖, 1↑ 9↓)
datafusion / vortex-compact (1.360x ❌, 0↑ 14↓)
datafusion / parquet (0.921x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.036x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.031x ➖, 0↑ 1↓)
duckdb / parquet (0.303x ✅, 22↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.896x ✅, 12↑ 0↓)
datafusion / vortex-compact (0.908x ➖, 9↑ 0↓)
datafusion / parquet (0.979x ➖, 2↑ 2↓)
datafusion / arrow (0.864x ✅, 17↑ 0↓)
duckdb / vortex-file-compressed (0.898x ✅, 12↑ 0↓)
duckdb / vortex-compact (0.896x ✅, 10↑ 0↓)
duckdb / parquet (0.933x ➖, 12↑ 2↓)
duckdb / duckdb (0.827x ✅, 18↑ 1↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.871x ✅, 4↑ 0↓)
datafusion / vortex-compact (0.979x ➖, 1↑ 0↓)
datafusion / parquet (0.989x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.059x ➖, 1↑ 4↓)
duckdb / vortex-compact (0.946x ➖, 2↑ 0↓)
duckdb / parquet (0.971x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.949x ➖, 8↑ 0↓)
datafusion / vortex-compact (0.972x ➖, 1↑ 0↓)
datafusion / parquet (0.970x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (0.987x ➖, 5↑ 2↓)
duckdb / vortex-compact (0.990x ➖, 4↑ 4↓)
duckdb / parquet (0.981x ➖, 2↑ 1↓)
duckdb / duckdb (0.979x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.001x ➖ datafusion / vortex-file-compressed (1.001x ➖, 1↑ 0↓)
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.172x ➖, 0↑ 3↓)
datafusion / vortex-compact (1.025x ➖, 0↑ 0↓)
datafusion / parquet (0.973x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.198x ➖, 0↑ 4↓)
duckdb / vortex-compact (1.032x ➖, 0↑ 1↓)
duckdb / parquet (1.029x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.970x ➖, 2↑ 0↓)
duckdb / vortex-compact (1.014x ➖, 0↑ 0↓)
duckdb / parquet (0.982x ➖, 0↑ 0↓)
Full attributed analysis
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessVortex (geomean): 0.758x ✅ unknown / unknown (0.836x ✅, 41↑ 1↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 0.913x ➖ unknown / unknown (0.887x ✅, 35↑ 0↓)
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
joseph-isaacs
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # Cargo.lock
AdamGS
reviewed
Mar 20, 2026
| /// - `T` for text/string types | ||
| /// - `B` for boolean | ||
| /// - `P` for timestamp/date types | ||
| pub fn slt_type_char(&self) -> char { |
Contributor
There was a problem hiding this comment.
I think this is at least somewhat handled in the SLT crate itself
AdamGS
reviewed
Mar 20, 2026
vortex-bench/src/validation.rs
Outdated
| /// `sqllogictest::default_validator` with `datafusion_sqllogictest::value_normalizer`. | ||
| /// | ||
| /// Returns `Ok(())` if the results match, or `Err` with a diff description. | ||
| pub fn validate_against_slt( |
Contributor
There was a problem hiding this comment.
Why do we need to do this on our own?
Contributor
|
I only realized what you're trying to do here over the weekend, WDYT about folding it into |
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # Cargo.lock
joseph-isaacs
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use slt (sql logic test) to validate benchmark runs.