Skip to content

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Feb 11, 2026

fix #6436

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2026

Merging this PR will not alter performance

✅ 1135 untouched benchmarks
⏩ 1268 skipped benchmarks1


Comparing rk/reducenode (47d5477) with develop (39425ae)2

Open in CodSpeed

Footnotes

  1. 1268 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (dbe0ff5) during the generation of this report, so 39425ae was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@robert3005 robert3005 added the changelog/performance A performance improvement label Feb 11, 2026
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
@robert3005 robert3005 enabled auto-merge (squash) February 11, 2026 18:06
}
}

impl ReduceNode for ArrayRef {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a horrible naming in the trait

@robert3005 robert3005 merged commit 493dbb5 into develop Feb 12, 2026
50 of 51 checks passed
@robert3005 robert3005 deleted the rk/reducenode branch February 12, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScalarFnAbstractReduceRule is very slow

2 participants