Skip to content

register zstd buffers if enabled #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onursatici merged 2 commits into from
Feb 11, 2026
Merged

register zstd buffers if enabled #6422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f28f5c
register zstd buffers if enabled
onursatici Feb 11, 2026
72759d3
test
onursatici Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vortex-file/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,11 @@ pub fn register_default_encodings(session: &mut VortexSession) {
arrays.register(ZigZagVTable::ID, ZigZagVTable);
#[cfg(feature = "zstd")]
arrays.register(vortex_zstd::ZstdVTable::ID, vortex_zstd::ZstdVTable);
#[cfg(all(feature = "zstd", feature = "unstable_encodings"))]
arrays.register(
vortex_zstd::ZstdBuffersVTable::ID,
vortex_zstd::ZstdBuffersVTable,
);
}

// Eventually all encodings crates should expose an initialize function. For now it's only
Expand Down
3 changes: 3 additions & 0 deletions vortex-test/e2e/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ version = { workspace = true }
[lints]
workspace = true

[features]
unstable_encodings = ["vortex/unstable_encodings"]

[dependencies]
futures = { workspace = true }
rstest = { workspace = true }
Expand Down
3 changes: 3 additions & 0 deletions vortex-test/e2e/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ mod tests {
PrimitiveArray::new(Buffer::from_iter(values), Validity::NonNullable).into_array();

// Write in parallel and verify all sizes match expected
#[cfg(feature = "unstable_encodings")]
const EXPECTED_SIZE: usize = 216188;
#[cfg(not(feature = "unstable_encodings"))]
const EXPECTED_SIZE: usize = 216156;
let futures: Vec<_> = (0..5)
.map(|_| {
Expand Down
Loading