-
Notifications
You must be signed in to change notification settings - Fork 131
Scalar truncation is implemented over scalar values instead of scalars and can operate in place #6414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Merging this PR will improve performance by 34.63%
Performance Changes
Comparing Footnotes
|
…s and can operate in place Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
2aaf10e to
4c5edf7
Compare
|
|
||
| #[test] | ||
| fn lower_bound() { | ||
| let utf8 = Scalar::utf8("snowman⛄️snowman", Nullability::NonNullable); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't believe we're losing this amazing test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh it just moved 😍
As a followup to the massive scalar refactor I have refactored the truncation logic to not require typed scalars. Since we now guarantee that values will be coerced to appropriate scalar value we can implement truncation logic over the underlying primitives
closes #6413