feat[array]: move over fill_null to scalar_fn array making it lazy#6406
Merged
joseph-isaacs merged 8 commits intodevelopfrom Feb 11, 2026
Merged
feat[array]: move over fill_null to scalar_fn array making it lazy#6406joseph-isaacs merged 8 commits intodevelopfrom
joseph-isaacs merged 8 commits intodevelopfrom
Conversation
joseph-isaacs
force-pushed
the
ji/fill-null-inline
branch
from
8463666 to
f892463
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Merging this PR will degrade performance by 54.87%
Performance Changes
Comparing 
Footnotes
|
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/fill-null-inline
branch
from
de092ce to
1357b0c
Compare
robert3005
reviewed
Feb 11, 2026
| /// let array = fill_null(array.as_ref(), &Scalar::from(42i32)).unwrap(); | ||
| /// assert_eq!(array.display_values().to_string(), "[0i32, 42i32, 1i32, 42i32, 2i32]"); | ||
| /// ``` | ||
| // TODO(joe): deprecate me. |
Contributor
There was a problem hiding this comment.
can you add deprecated now?
Contributor
Author
There was a problem hiding this comment.
that is 100s more lines
robert3005
reviewed
Feb 11, 2026
| cast::warm_up_vtable(); | ||
| compare::warm_up_vtable(); | ||
| fill_null::warm_up_vtable(); | ||
|
|
Contributor
Author
|
I will follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of: #5921