Replace xbps_file_hash_check_dictionary#582
Open
Duncaen wants to merge 8 commits intovoid-linux:masterfrom
Open
Replace xbps_file_hash_check_dictionary#582Duncaen wants to merge 8 commits intovoid-linux:masterfrom
xbps_file_hash_check_dictionary#582Duncaen wants to merge 8 commits intovoid-linux:masterfrom
Conversation
Duncaen
force-pushed
the
replace-xbps_hash_file_check_dictionary
branch
from
89889d5 to
b1831a6
Compare
Duncaen
force-pushed
the
replace-xbps_hash_file_check_dictionary
branch
from
8168470 to
06981f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #359, same results slightly different with less changes and ready to merge.
xbps_file_hash_check_dictionarywas called for every file that isgetting unpacked, because the files list is an array it iterated over
the whole files array to find the matching file.
With a lot of files this is really slow and a lot of time was spend
in locking the proplib array and iterating over it.
Time from my Ryzen 3700X system with nvme disk updating
texlive-fontsextra with files 86375:
And with this patch: