Draft
Conversation
Contributor
Author
|
I will have to look into the musl build |
ahesford
reviewed
Apr 7, 2026
| @@ -0,0 +1,5 @@ | |||
| case "${ACTION}" in | |||
| post) | |||
| install -dm0755 etc/ananicy.d | |||
Member
There was a problem hiding this comment.
We have make_dirs to declare this in the template. Don't roll your own INSTALL script for this.
ahesford
reviewed
Apr 7, 2026
Member
ahesford
left a comment
ahesford
left a comment
There was a problem hiding this comment.
I'm not sure that the service should be tweaking sysctls. Let people configure their systems to support the daemon if they want to run it. In any case, there is no good reason for using two different approaches to setting sysctls in the run and finish scripts.
| pkgname=ananicy-cpp | ||
| version=1.2.0 | ||
| revision=1 | ||
| archs="x86_64*" |
Member
There was a problem hiding this comment.
Is this really limited to these architectures?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Local build testing