Skip to content

right way handle error for sendUTF method#32

Merged
ibc merged 1 commit intoversatica:masterfrom
anchmelev:bag/right-way-handle-error-for-sendUTF
Mar 15, 2026
Merged

right way handle error for sendUTF method#32
ibc merged 1 commit intoversatica:masterfrom
anchmelev:bag/right-way-handle-error-for-sendUTF

Conversation

@anchmelev
Copy link
Contributor

Title: Improved Message Sending Handling in WebSocketTransport

Description:
The purpose of this pull request is to enhance the reliability and error handling of the send method in the WebSocketTransport class. The changes include making the send method return a promise, allowing the calling code more flexibility in managing the sending process and appropriately responding to different outcomes of the operation.

Key Changes:

  1. The send method now returns a promise, enabling the handling of success or error events of the sending process.
  2. Additional error handling and logging logic has been introduced, increasing the ease of debugging and monitoring.

These changes make the send method more robust and predictable in use, especially in scenarios that require confirmation of message delivery.

I request the review and approval of these changes as they improve the functionality and reliability of the WebSocketTransport.

@anchmelev
Copy link
Contributor Author

Hi @ibc , just a gentle ping on this PR.

This change has been open for a while, and I’d really appreciate a quick review when you have time.
If the approach is not suitable, I’d be grateful for any feedback so I can rework it.

Thanks!

@ibc
Copy link
Member

ibc commented Mar 13, 2026

Will do soon, sorry.

@ibc ibc merged commit fb2c6f3 into versatica:master Mar 15, 2026
@ibc
Copy link
Member

ibc commented Mar 15, 2026

Merged. Will release a new version soon.

BTW, next time please run npm run lint, there are ESLint errors (I'm fixing them locally).

@ibc
Copy link
Member

ibc commented Mar 15, 2026

protoo-server 4.0.8 released. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants