right way handle error for sendUTF method#32
Merged
ibc merged 1 commit intoversatica:masterfrom Mar 15, 2026
Merged
Conversation
Contributor
Author
|
Hi @ibc , just a gentle ping on this PR. This change has been open for a while, and I’d really appreciate a quick review when you have time. Thanks! |
Member
|
Will do soon, sorry. |
Member
|
Merged. Will release a new version soon. BTW, next time please run |
Member
|
protoo-server 4.0.8 released. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Improved Message Sending Handling in WebSocketTransport
Description:
The purpose of this pull request is to enhance the reliability and error handling of the send method in the WebSocketTransport class. The changes include making the send method return a promise, allowing the calling code more flexibility in managing the sending process and appropriately responding to different outcomes of the operation.
Key Changes:
These changes make the send method more robust and predictable in use, especially in scenarios that require confirmation of message delivery.
I request the review and approval of these changes as they improve the functionality and reliability of the WebSocketTransport.