pgrep: The pattern is too long (more than 15 characters) and should be able to match pid correctly.

[Franklin-Qi]

The PIDs should be obtained in advance. If the PIDs exist, it means the pattern matches, and there should be no length error.

Closes: #121

[dezgeg]

Would be better to add the check to find_matching_pids (I think), calling collect_matched_pids() will essentially halve performance of the program

[Franklin-Qi]

Would be better to add the check to find_matching_pids (I think), calling collect_matched_pids() will essentially halve performance of the program

@dezgeg Thanks for the feedback. Calling the collect_matched_pids function twice does indeed impact performance. Moving the length error information to the subsequent find_matching_pids might be a better idea.

[cakebaker]

Thanks for your PR!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (7b77e2f) to head (54fbe8c).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #617   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dezgeg]

I now noticed there's a pre-existing bug - if -x is used the length check is off by two characters (due to added ^$) - ie. cargo run pgrep -x 12345678901234 will trigger the message.

[Franklin-Qi]

@dezgeg Yeah, I tested this issue, and it did exist before. Perhaps we can raise an new issue about it, and I will resolve it later.