Skip to content

Publish libstdbuf.so at release page#10825

Closed
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:pub-libstdbuf
Closed

Publish libstdbuf.so at release page#10825
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:pub-libstdbuf

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 8, 2026

  1. Publish libstdbuf.so
  2. Stop building same release binaries twice on the CI

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@oech3

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

@oech3 oech3 marked this pull request as ready for review February 9, 2026 05:54
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

@oech3
Copy link
Contributor Author

oech3 commented Feb 12, 2026

While dedup is still useful, LIBSTDBUF_DIR does not wrok as I expected. So needed to manually copy...

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/chcon/chcon is no longer failing!
Congrats! The gnu test tests/cp/no-ctx is no longer failing!

@oech3 oech3 force-pushed the pub-libstdbuf branch 2 times, most recently from 828df76 to 22b0e39 Compare February 25, 2026 00:40
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2026

Merging this PR will degrade performance by 3.46%

❌ 1 regressed benchmark
✅ 303 untouched benchmarks
⏩ 42 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation true_no_args 813.3 ns 842.5 ns -3.46%

Comparing oech3:pub-libstdbuf (0f9bba6) with main (e6a3bb5)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

@oech3
Copy link
Contributor Author

oech3 commented Mar 3, 2026

@Ecordonnier @cakebaker Would you merge this? We are building release binaries for Linux 3 times. We should dedup one of them.

- name: Package
shell: bash
run: |
mv target/release/deps/libstdbuf.so -t /tmp/individual/usr/local/bin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the move of libstdbuf.so needed? Can't you set LIBSTDBUF_DIR to "/usr/local/bin" ? Then it will get installed to the proper location by GNUmakefile line 294

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did not include *.so to release archive by unknown reason.

@Ecordonnier
Copy link
Collaborator

@Ecordonnier @cakebaker Would you merge this? We are building release binaries for Linux 3 times. We should dedup one of them.

Can you please extend the PR description to describe the issue getting solved? libstdbuf.so is already getting installed by GNUmakefile, so it's obvious to me why it's missing.

@oech3 oech3 changed the title Publish missing libstdbuf.so Publish libstdbuf.so at release page Mar 5, 2026
@oech3
Copy link
Contributor Author

oech3 commented Mar 5, 2026

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3
Copy link
Contributor Author

oech3 commented Mar 10, 2026

done at different PR. CICD.yml was separated.

@oech3 oech3 closed this Mar 10, 2026
@oech3 oech3 deleted the pub-libstdbuf branch March 10, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants