Sort: bench ahash

[oech3]

No description provided.

[codspeed-hq]

Merging this PR will improve performance by 13.54%

⚡ 5 improved benchmarks
✅ 279 untouched benchmarks
⏩ 38 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Simulation	sort_case_insensitive[500000]	257.2 ms	249 ms	+3.28%
⚡	Simulation	sort_general_numeric[200000]	721.1 ms	659.5 ms	+9.33%
⚡	Simulation	sort_key_field[500000]	853.4 ms	783.2 ms	+8.96%
⚡	Simulation	sort_dictionary_order[500000]	1.1 s	1 s	+9.79%
⚡	Simulation	sort_numeric[500000]	1.2 s	1 s	+13.54%

---

_{Comparing oech3:sort-ahash (99fa0ed) with main (1f4a976)}

Footnotes

1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sylvestre]

Merging this PR will improve performance by 14.56%

impressive!

[xtqqczze]

Merging this PR will improve performance by 14.56%

Interesting, using rustc-hash showed no change in #10690

[oech3]

Interesting, using rustc-hash showed no change in

Because I kept 1 Fnv to unbreak sort -R. I will test rustc-hash at internal Hash* (non-RNG part).

[oech3]

Also we reciently applied codegen-units=1 to release profile.
So previous 9.* % is not used for comparison.

[xtqqczze]

it's probably worth trying foldhash as well?

[sylvestre]

why "as _" ?

[oech3]

to avoid confliction in the future.

[oech3]

Applying clippy removed it...

[sylvestre]

i would prefer we don't have this
it is a pretty ugly in the code base
i would prefer you remove the " as " in use ahash::AHashMap as HashMap;
instead
and change the name
it isn't like we are going not change the hashmap on a regular basis

[oech3]

@xtqqczze recommended shadowing. Should we revert also for other utils?

I switched to AHash* at here anyway.

[sylvestre]

yes, i don't like shadowing

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)